test(fprintd): xfail --finger in container #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedayak
force-pushed
the
fprintd-skip-no-dbus
branch
from
0861966 to
42e2ba3
Compare
yedayak
changed the title
scop
approved these changes
May 10, 2025
test/t/test_fprintd_enroll.py
Outdated
| @@ -13,6 +15,9 @@ def test_basic(self, completion): | |||
| def test_options(self, completion): | |||
| assert completion | |||
|
|
|||
| @pytest.mark.xfail( | |||
There was a problem hiding this comment.
Suggested change
| @pytest.mark.xfail( | |
| @pytest.mark.skipif( |
I think we should be skipping and not xfailing tests in scenarios like this. We seem to have the same problem in at least some of our xfail vs skip uses and should review and fix them all up in another PR. (For example, in strict xfail mode, an unexpected pass would cause the tests to fail.)
- https://docs.pytest.org/en/stable/how-to/skipping.html
- https://docs.pytest.org/en/stable/how-to/skipping.html#strict-parameter
Pre-approved with that addressed.
Containers usually don't have fingerprint readers Co-Authored-By: Ville Skyttä <[email protected]>
yedayak
force-pushed
the
fprintd-skip-no-dbus
branch
from
42e2ba3 to
7d7062e
Compare
|
Created #1380 for the ubuntu 14 fail, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers usually don't have fingerprint readers